Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CustomerIORequestError as an export for this package #108

Merged
merged 1 commit into from
May 4, 2022

Conversation

daimenworrall-cinch
Copy link
Contributor

We needed to handle errors and were importing the type from customerio-node/dist/lib/utils which doesn't feel right, so i have added an export in index.ts for this type.

@mike-engel mike-engel merged commit 49e78a5 into customerio:main May 4, 2022
@daimenworrall-cinch daimenworrall-cinch deleted the export-error-type branch May 4, 2022 15:44
@daimenworrall-cinch
Copy link
Contributor Author

@mike-engel thank you for approving that. I noticed the change didn't translate into the actual release (ie: the change isn't in the dist directory)

I may have missed something, but what happened?

Thank you again

@mike-engel
Copy link
Collaborator

@daimenworrall-cinch I'm not sure exactly what happened! The tarball for 3.3.1 has the correct index.ts, but the dist/index.d.ts has the old version. We have a prepublish task which is supposed to build it, but after double checking, the build that ran before the last publish generated the old code. No idea why! I'm going to publish 3.3.2 shortly to try and remedy this.

@mike-engel mike-engel mentioned this pull request May 5, 2022
@mike-engel
Copy link
Collaborator

@daimenworrall-cinch I just published 3.3.2, and verified that the types file is correct now. Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants